search

dominic-p / videojs-resolution-selector

Adds a resolution selector button to Video.js to allow users to manually adjust the video quality.
MIT License
88 stars 31 forks source link

Can't see change resolution button #24

Closed CKalnasy closed 9 years ago

CKalnasy commented 9 years ago

Everything works as it should except I cannot see the button text that changes the resolution. The button is there, but the text is not visible. This fiddle shows the issue: https://jsfiddle.net/5ptz30dL/. I tried using previous versions of video.js and this issue still persists.

Looking at the HTML when I change resolutions, the text is changed accordingly. I can't figure out why the span tag showing the text isn't visible.

CKalnasy commented 9 years ago

I found out that the text of video.js control buttons are actually never shown. The absolute positioning causes this. I guess this kinda makes sense since we are probably supposed to add an image there instead.

CKalnasy commented 9 years ago

Ok, so add an image and it works. Maybe should point this out in the readme?

dominic-p commented 9 years ago

@CKalnasy, checkout the button-styles.css file. If you include those styles, the plain text will be visible (see this fiddle)