search

dominic-p / videojs-resolution-selector

Adds a resolution selector button to Video.js to allow users to manually adjust the video quality.
MIT License
88 stars 31 forks source link

Reorganized for bower and npm #28

Closed stopspazzing closed 9 years ago

stopspazzing commented 9 years ago

Reorganized everything so could be used with bower and npm. No bower or npm packages were created or setup, just first initial pre-setup.

stopspazzing commented 9 years ago

Please review and take a look. If this is correct would fix issue 23. All that needs to be done is create the bower and npm packages aka register them. I am unsure if this would work or not, because never set up a package for bower or npm before, used another github project as an example for both.

dominic-p commented 9 years ago

Thanks for putting this together. I don't use npm or bower in my workflow, but looking at the files, I see references to a dist directory. However, there isn't one in your fork. I imagine you would store the minified js and css files there. Do you know if that's required for the package managers to work properly? Is it possible to test this in anyway before I merge it?

stopspazzing commented 9 years ago

I'm not 100% sure the answer to the last 2 questions, I can find out tho. I do use bower and npm so I can test it if it is possible. What I did was pretty much copy https://github.com/eXon/videojs-youtube

So... xD

dominic-p commented 9 years ago

Thanks for checking on that. Pleas let me know how the testing goes. Looking at videojs-youtube, it looks like they have an automated build process setup that generates a dist folder which is included in their releases. I wonder if bower grabs the latest release or just the current master branch.

stopspazzing commented 9 years ago

Bower package works fine, still making sure puts files in right location.

bower install https://github.com/stopspazzing/videojs-resolution-selector.git
bower not-cached    https://github.com/stopspazzing/videojs-resolution-selector.git#*
bower resolve       https://github.com/stopspazzing/videojs-resolution-selector.git#*
bower checkout      videojs-resolution-selector#master
bower resolved      https://github.com/stopspazzing/videojs-resolution-selector.git#f649736f95
videojs-resolution-selector#f649736f95 bower_components/videojs-resolution-selector
└── video.js#4.12.6

"I wonder if bower grabs the latest release or just the current master branch."

Good question, I'm not sure, as when I grab video.js still grabbing stable 4.12.6 branch, and not the master unstable 5.x branch.

stopspazzing commented 9 years ago

Bower is working great, now to test npm

stopspazzing commented 9 years ago

NPM is working without issues, should work fine once committed. Need to be added to npm registry so people can grab it globally, still trying to figure out this command, has to be run from folder of package with package.json in it.

dominic-p commented 9 years ago

Alright, this is looking pretty good. I'll go ahead and pull it in and register the package with NPM and Bower. Feel free to make additional pull requests with recommended tweaks to the package management systems as they are needed.

Thanks for taking the time to get this working.