search

dominic-p / videojs-resolution-selector

Adds a resolution selector button to Video.js to allow users to manually adjust the video quality.
MIT License
88 stars 31 forks source link

Needs updating to support videojs 5.0 #36

Open paladox opened 9 years ago

paladox commented 9 years ago

Hi this needs updating to support videojs 5.0.

dominic-p commented 9 years ago

It sure does. Pull requests welcome. :)

paladox commented 9 years ago

Well there are some fixes here https://git.wikimedia.org/raw/mediawiki%2Fextensions%2FTimedMediaHandler/ae23f54bfa559b5846b4e0f213e89c6250687370/resources%2Fvideojs-resolution-selector%2Fvideo-quality-selector.js but my edit should be changed back to original since they are Wikimedia specific.

dominic-p commented 9 years ago

Thanks for that file. It will certainly help when I get around to working on 5.0 compatibility. Out of curiosity, is Wikimedia using Video.js with this plugin as their video player?

paladox commented 9 years ago

Currently wikimedia are currently deciding to choose a different video player and choose video.js to try. And yes the plugin was updated manually by another user working on the patch.

paladox commented 9 years ago

videojs 5.0 has been released.

dominic-p commented 9 years ago

Just wanted to let you know I saw the pull request. Life has been pretty hectic for me, so I haven't had a chance to look at it yet. One concern I have is that it looks like it breaks compatibility with Video.js 4.x.

Do you know if it could be tweaked to work with both?

paladox commented 9 years ago

I doint think so but maybe you can create a branch for vjs 4.0 compat and use master to stay compat with latest vjs release.

RomanEmelyanov commented 8 years ago

For 5.0 version use https://github.com/kmoskwiak/videojs-resolution-switcher