dominicfeliton / WorldwideChat

WorldwideChat plugin for Spigot, Paper, and Folia on 1.13+.
14 stars 3 forks source link

Not chat translated #360

Closed NicolasLasch closed 3 months ago

NicolasLasch commented 9 months ago

What version of WorldwideChat are you running? Last Version

What version of Minecraft/platform is your server running on? My server is running minecraft version 1.18.2, with Magma.

Describe the bug The chat isn't being translated once the message is sent.

To Reproduce IDK

Expected behavior it should translate and isn't. Maybie it is due to another plugin

dominicfeliton commented 9 months ago

Hi there! Thanks for filing a bug report. Did you enable chat translation with /translate? Are there any logs in console?

NicolasLasch commented 9 months ago

Hi there! Thanks for filing a bug report. Did you enable chat translation with /translate? Are there any logs in console?

Yes, the translation works for everything beside chat translation. I don't know where it comes from there is no error in the console...

NicolasLasch commented 9 months ago

and btw, there is a lot of time where it's written sign translated and it isn't

dominicfeliton commented 9 months ago

Interesting. Could you turn on debug mode (https://github.com/BadSkater0729/WorldwideChat/wiki/Default-Explained-config.yml), try chat translation again and then send your console logs? Also what's your plugin list? You're not providing much information here for me to work with...

NicolasLasch commented 9 months ago

Here are the logs in debug mod : (and a picture of the plugins I have) [13:37:18] [pool-29-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Cache lookup outcome: null [13:37:18] [pool-29-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Translating a message (in None) from c7038e0e-dafc-4bcc-9f0c-dbd43aa9b147 to en-GB. [13:37:18] [pool-29-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Removed least used phrase in cache if at hard limit. Size after removal test: 1 [13:37:18] [pool-29-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Added new phrase into cache! Size after addition: [13:37:18] [Server thread/INFO] [/]: ⡡ TheSpattt >> j'vais m'immoler c'est bon :cccccccc [13:37:25] [Server thread/INFO] [minecraft/ServerGamePacketListenerImpl]: Sempeii issued server command: /msg TheSpattt test [13:37:25] [Server thread/INFO] [/]: ⡗ PhenixReturn >> on te voit pas sur la liste [13:37:32] [pool-31-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Cache lookup outcome: null [13:37:32] [pool-31-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Translating a message (in None) from c7038e0e-dafc-4bcc-9f0c-dbd43aa9b147 to en-GB. [13:37:32] [pool-31-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Removed least used phrase in cache if at hard limit. Size after removal test: 2 [13:37:32] [pool-31-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Added new phrase into cache! Size after addition: [13:37:32] [Server thread/INFO] [/]: ⡡ TheSpattt >> jss suis vanish [13:37:39] [Server thread/INFO] [minecraft/ServerGamePacketListenerImpl]: Sempeii issued server command: /msg TheSpattt c bon ? [13:37:40] [Server thread/INFO] [minecraft/DedicatedServer]: Zokozs has made the advancement [Hearty Meal] [13:37:53] [Server thread/INFO] [/]: ⡗ Sempeii >> askip je tes mp [13:38:00] [pool-33-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Cache lookup outcome: null [13:38:00] [pool-33-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Translating a message (in None) from c7038e0e-dafc-4bcc-9f0c-dbd43aa9b147 to en-GB. [13:38:01] [pool-33-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Removed least used phrase in cache if at hard limit. Size after removal test: 3 [13:38:01] [pool-33-thread-1/WARN] [co.ba.wo.WorldwideChat/]: [WorldwideChat] DEBUG: Added new phrase into cache! Size after addition: [13:38:01] [Server thread/INFO] [/]: ⡡ TheSpattt >> c'est good ça marche pas :) [13:38:04] [Server thread/INFO] [/]: ⡗ Sempeii >> okok [13:38:14] [Server thread/INFO] [/]: ⡗ PhenixReturn >> c'est le mode trad? Capture

NicolasLasch commented 8 months ago

Have you been able to look at the issue ?

dominicfeliton commented 8 months ago

Hi Nicolas,

While Magma is not really a supported platform, I'll definitely take a look and keep you updated. I'm still working on the next major revision of WWC and I've been very busy with uni. Will post back here when I have a fix for you guys

dominicfeliton commented 7 months ago

Nicolas,

I ran my latest dev build of WorldwideChat on Magma and it seems to work without a hitch. I saw that you used /msg to test out this plugin, and that may be where your issue lies. This plugin does not currently translate /msg commands (because this is handled by essentialsX or a similar plugin, but may be added in a future release). It only translates publicly sent messages. I need a bit more specific details of which translator you're using, when it happens, etc. to properly diagnose your issue since Magma (a platform I don't directly support) works just fine with this plugin.

You can also try the latest dev build (https://github.com/BadSkater0729/WorldwideChat/actions/runs/8422347767/artifacts/1356061070), just make sure to use WorldwideChat-spigot.jar for Magma and not paper.

dominicfeliton commented 7 months ago

Hi Nicolas,

Do you have any further updates on this issue? It seems to be getting a bit stale and I'll close it out by the end of the month if you're all set.

NicolasLasch commented 7 months ago

Hi Nicolas,

Do you have any further updates on this issue? It seems to be getting a bit stale and I'll close it out by the end of the month if you're all set.

Hello, it still isn't working. I think it's happening because I'm using a prefix plugin and wwc don't like that.

dominicfeliton commented 7 months ago

Ahhh SimplePrefix? I can take a look at that. Does it still not work even on 1.15.1?

NicolasLasch commented 7 months ago

Ahhh SimplePrefix? I can take a look at that. Does it still not work even on 1.15.1?

We tryied to update but it was even worse. Maybe we had to configure something else. I'm gonna look tonight :)

dominicfeliton commented 7 months ago

Well that's really disappointing! I'll try mimicking your plugin setup in a little while and taking a look then. Sorry to hear it's not working right for you guys!

NicolasLasch commented 7 months ago

Well that's really disappointing! I'll try mimicking your plugin setup in a little while and taking a look then. Sorry to hear it's not working right for you guys!

No problem, thanks for making this plugin. It's really cool when it works :p

dominicfeliton commented 7 months ago

So I just checked, and we definitely have an incompatibility with SimplePrefix. I'll see if we can fix it but it looks like SimplePrefix is overwriting the existing chat format entirely in Spigot's AsyncPlayerChatEvent. While this makes sense for the plugin, it might be why it does not work with WWC. I'll see if I can change this plugin but this may be an issue with Simple Prefix.

dominicfeliton commented 7 months ago

Nicolas,

Could you try testing 1.15.2? I need to ensure compatibility with other chat plugins when I do this, but now we change the chat before the message is processed by any other plugin. This works for outgoing messages, but I have a feeling that incoming messages will lack a prefix from SimplePrefix. I'd really appreciate you testing this behavior; I hope to have a more concrete fix for the real 1.15.2/1.16.0

Download it here: https://github.com/BadSkater0729/WorldwideChat/actions/runs/8652838277/artifacts/1406532643

NicolasLasch commented 7 months ago

Nicolas,

Could you try testing 1.15.2? I need to ensure compatibility with other chat plugins when I do this, but now we change the chat before the message is processed by any other plugin. This works for outgoing messages, but I have a feeling that incoming messages will lack a prefix from SimplePrefix. I'd really appreciate you testing this behavior; I hope to have a more concrete fix for the real 1.15.2/1.16.0

Download it here:

https://github.com/BadSkater0729/WorldwideChat/actions/runs/8652838277/artifacts/1406532643

I'm gonna try this as soon as I can but rn it's hard for me. I'll let you know when It will be tested

dominicfeliton commented 7 months ago

No rush! I'll do some testing as well soon but that's the only version I can push out for a while. It should fix your issue but it may include complications with other plugins/setups which I will diagnose before the next major version is released

dominicfeliton commented 6 months ago

Hi @NicolasLeech, is this hotfix working for you?

NicolasLasch commented 6 months ago

Hi @NicolasLeech, is this hotfix working for you?

Sry, completely forgot to test it. I'll message you when it's done !

NicolasLasch commented 6 months ago

Hi @NicolasLeech, is this hotfix working for you?

Hello, where is the hotfix available, I would like to test it but can't find a new version (the last one I can download is the one from 3 weeks ago :c)

NicolasLasch commented 6 months ago

Nicolas,

Could you try testing 1.15.2? I need to ensure compatibility with other chat plugins when I do this, but now we change the chat before the message is processed by any other plugin. This works for outgoing messages, but I have a feeling that incoming messages will lack a prefix from SimplePrefix. I'd really appreciate you testing this behavior; I hope to have a more concrete fix for the real 1.15.2/1.16.0

Download it here: https://github.com/BadSkater0729/WorldwideChat/actions/runs/8652838277/artifacts/1406532643

So just tested it, and it still doesn't work. Works when I remove SimplePrefix :3

dominicfeliton commented 6 months ago

Hey Nicolas,

Thanks for testing this out. It looks like we simply are incompatible with SImplePrefix :(. The developer uses the setFormat() method in AsyncPlayerChatEvent which messes with our ability to set the translated message properly. I'll push a hotfix to 1.16.0 if I do find a workaround but this seems to be something that the SimplePrefix dev can look into. I'll keep this issue open for a little while.

dominicfeliton commented 3 months ago

Hi Nicolas,

I'm closing out this issue, but 1.18.0 adds Vault support and it seems that that fixes incoming messages. Outgoing messages seem to be messed up because of a decision made by the developer of SimplePrefix.

dominicfeliton commented 2 months ago

Hi @NicolasLasch ,

This plugin now supports SimplePrefix. Please update to 1.18.0 and set Chat.separateChatChannel.force to true.

NicolasLasch commented 2 months ago

Thank you ! Nice work 👍🏼