search

dominichofer / DeePC

MIT License
3 stars 0 forks source link

cpp data quality, exposing henkel matrix. #26

Open marvin-ad-martianum opened 2 weeks ago

marvin-ad-martianum commented 2 weeks ago

its very difficult to asses data quality in this case. however, for any usable implementation i will need some checks. therefore condition number, rank and singular values of the core matrices are important nrs to be able to calculate in cpp and python. therefore i suggest either adding this functionality or exposing these matrices such that i can add the code externally.

dominichofer commented 2 weeks ago

Would https://github.com/dominichofer/DeePC/pull/27 give you sufficient access to the matrix?

marvin-ad-martianum commented 2 weeks ago

maybe do it with the four matrices. i gave an example of two heuristics and important checks on the commit https://github.com/dominichofer/DeePC/commit/4c49f7d2caa17a7ca9b308deeb294739d706031c

i will need to do some analysis of this sort before i deploy a controller.