Would people prefer me and @ograycode to use pull requests

dominickm / jupiter_broadcasting_mobile_community

The Jupiter Broadcasting community project.

Other

100 stars 17 forks source link

Would people prefer me and @ograycode to use pull requests #21

Closed ShaneQful closed 11 years ago

ShaneQful commented 11 years ago

Now that me and @ograycode have push access to the repo. I have just been pushing my commit straight up with no peer review would people prefer if I/We used pull requests so our code was reviewed before it was let into the repo?

On a side note due to my pushing straight from my repo, the player now works for the feeds and the audio live streams :)

ghost commented 11 years ago

I think that the code should be peer reviewed. Plus it makes it a little unfair especially if you commit code that doesn't comply with the style guide.

ShaneQful commented 11 years ago

@Techfix I agree with you on your first point but I'm way to anal-retentive to commit code that didn't agree with the style guide ;P
The main issue will be if @ograycode or @dominickm is willing to do the merging because whilst most code will auto-merge it won't always and will mean more work that no one would have had to do before hand.
I don't mind the little bit of extra work assuming we agree it will help the project
Also people can always critique my / @ograycode's code once its in the repo.

ghost commented 11 years ago

Unless there is a way to separate the role of managing the repository and developing it so that the code can be approved by multiple people then it doesn't really matter. As the decision making power is granted to @ShaneQful and @ograycode at the end of the day.

If there were a way to make it that all contributors could QA/review the pull requests then that would be ideal. However this could also slow the development process down.

Personal I really don't care too much about how the repo is managed provided that we work towards the same goals, work in a productive manner and produce a good quality application.

The other problem is testing. We will need to define exactly how we intend to test this application. How can you QA something without defining what we are looking for?

ograycode commented 11 years ago

At this point, I am always willing to do a pull request for it to be reviewed before.

I haven't been too active on this project because of work and personal commitments these past two weeks, but hope to be soon.

ShaneQful commented 11 years ago

@ograycode will you be willing to merge my pull requests?

ograycode commented 11 years ago

Ya. I may wait a day or two for comments, as I'm more interested in it working than style, unless it's just grossly wrong.

ShaneQful commented 11 years ago

Awesome peer review ftw :)