dominickm / jupiter_broadcasting_mobile_community

The Jupiter Broadcasting community project.
Other
100 stars 17 forks source link

Ditch JQuery Mobile #34

Closed ograycode closed 11 years ago

ograycode commented 11 years ago

I'm wondering if it may make more sense to scrap jquery mobile in favor of something more flexible. The only real advantage to jquery mobile, in my opinion, is page transitions, but those can be buggy depending on the device.

I've had success in the past using bootstrap for basic styling (responsive css and buttons), and then import other components only when necessary, such as jquery ui for gestures.

Combine that with a templating library, like handle bars, and we can avoid dom manipulation, which can become a nightmare as it can be too easy to couple the ui with the logic layers.

You end up having to do more work styling, but you're also free to have your app feel however you want.

ShaneQful commented 11 years ago

Don't mind but I'd rather just get something working but I can definitely see your point. There is quite a bit of code that is duplicated because of jquery mobile which I don't like if we change we have to throw out nearly everything but not that much is done.

ShaneQful commented 11 years ago

Sorry didn't mean to close this

ograycode commented 11 years ago

So, I didn't realize I was working on this repo instead of my own. Anyways, I created a quick demo of what a handlebars + bootstrap project may look like. I didn't run it through jslint or anything, just hacked it together.

https://github.com/dominickm/jupiter_broadcasting_mobile_community/tree/ditch-jquery-mobile

The code to me seems to be a lot cleaner, as well as the interface itself.

I understand the want to get something functional and to not throw away code, but I also think we haven't gone far enough in one direction to really warrant much of a concern with restarting. Being able to pull the feed and then stream should be the MVP, and this re-write already accomplishes one of those goals.

ShaneQful commented 11 years ago

Code is cleaner and we didn't have that much done anyway. I'm all for it :)

thornbill commented 11 years ago

Looks good to me. I'm using bootstrap + handlebars in another project and really haven't used jQuery mobile.