Some issues for Chinese

dominiclet / obsidian-note-definitions

MIT License

33 stars 2 forks source link

Some issues for Chinese #16

Closed emisjerry closed 4 weeks ago

emisjerry commented 1 month ago

Hi,

Here are my test(using v0.4.0), something wrong for Chinese:

Example1: WhatIsPUA 、CCR
範例2: Same Energy metaverse SPF SRS  // Starts with Chinese, detection failed
Example2: Same Energy metaverse SPF SRS  // Starts with English, detection succeed

Example2: Same Energy 元宇宙 metaverse SPF SRS  // Contains Chinese, some detection failed

dominiclet commented 1 month ago

Hi @emisjerry, thanks for bringing this up. At the moment, if a line contains any Chinese characters, the whole line will be treated (and parsed) as Chinese. So mixing English and Chinese in the same line will be problematic at the moment. But I'll look into solving this issue!

dominiclet commented 4 weeks ago

Improved definition search in 0.6.0. Both Chinese and English definitions can now be detected in the same line.