search

dominiclet / obsidian-note-definitions

Obsidian plugin for seamless viewing of personal definitions
MIT License
79 stars 4 forks source link

Hover/Underline does not work with non-latin symbols #17

Closed vkhatuntsevv closed 3 months ago

vkhatuntsevv commented 4 months ago

Hi, i work primarily in Russian language, and i noticed that the word is underlined only in English. not only that, i still can RMB and "Preview definition", but the hover does not work on such words. i wonder why can it not be underlined for any other text which fits PHRASE word? it also does not work with symbols like numbers

thanks in advance!

dominiclet commented 4 months ago

Hi! Cyrillic characters won't work at the moment. I originally only considered latin characters when writing this, but am currently looking at improving it to be a bit more general. I'll keep you updated on the progress!

dominiclet commented 3 months ago

@vkhatuntsevv I've updated the search algorithm in 0.6.0, which should work for non-latin characters. A simple test with Cyrillic characters seem to work as well. image I'll close this issue, but do let me know if there are still issues when using with Russian language.

vkhatuntsevv commented 3 months ago

wow, this was fast! thank you so much! right now everything works perfect!