dominiclet / obsidian-note-definitions

Obsidian plugin for seamless viewing of personal definitions
MIT License
66 stars 3 forks source link

Low Priority : Wikilinks don't work in definition popup (Markdown links work) #27

Open dmantisk opened 3 months ago

dmantisk commented 3 months ago

Currently markdown links ([text](link)) work inside the popups, but not wikilinks ([[text]])

As there's an easy workaround this is not a big issue

Edit : Only markdown links using obsidian url works. It seems if you auto generated links don't work in the definition window even if they are markdown links. You have to manually create the markdown link using the obsidian url. Like [text](obsidian url)

An auto generated markdown link looks like [text](note.md) while a link using obsidian url looks like [text](obsidian://open?vault=vault_name&file=folder%2Fnote)

dominiclet commented 3 months ago

Thanks for bringing this up. I noticed this too. Not sure why it happens, but I'll look into it.

Moyf commented 3 months ago

image

It's strange that even when I use the Markdown link format, the links are still not clickable for me. (I also can't see the Note Preview by pressing Ctrl and hover.)


Maybe it's because I'm using the "Shortest link" ? 🤔

dmantisk commented 3 months ago

It's strange that even when I use the Markdown link format, the links are still not clickable for me. (I also can't see the Note Preview by pressing Ctrl and hover.)

Markdown links don't support note preview (the popup window).

Maybe it's because I'm using the "Shortest link" ? 🤔

That's not it; Even absolute path doesn't work It seems if you auto generated links don't work in the definition window even if they are markdown links. You have to manually create the markdown link using the obsidian url. Like [text](obsidian url)

An auto generated markdown link looks like [text](note.md), while a link using obsidian url looks like [text](obsidian://open?vault=vault_name&file=folder%2Fnote)

dominiclet commented 2 months ago

Hi, managed to resolve this issue with a workaround, released in 0.16.1. You can give it a try. I'll keep this issue open for awhile, let me know if there's still any problems with this.

dmantisk commented 2 months ago

I can confirm that wiki links are working. Markdown links ([text](note)) don't work, but that's not an issue for me.

dominiclet commented 2 months ago

Thanks for confirming, do you have an example for markdown links not working? I tried on my end it seems to work fine.

dmantisk commented 2 months ago

Markdown links like [text](obsidian://open?vault=vault_name&file=folder%2Fnote) works. (It worked even before)

Markdown links like [text](note) still doesn't work

dominiclet commented 2 months ago

I've tested that markdown links in the [text](note) format works on my end too, is the markdown link that you're testing with valid?

FootPrintStudio commented 2 weeks ago

Not sure if this should be a new issue, but it appears to me it may be related.

Reading view is enabled and I use source mode for editing (I know that causes issues with some plugins). To be fair, it is a bit of a setup in my instance.

This is all the same links.

The red highlighted text is where it breaks a link, this is within an Admonitions code block, within an Obsidian Columns code block. The blue highlighted text is only within an Obsidian Columns code block. The yellow highlighted text is only within an Admonition code block. The black highlighted text isn't in any code block, just for reference.

image

Arguably it is the Admonitions, and Obsidian Columns plugins that are responsible; however, it is breaking at the highlighted word.

dmantisk commented 2 weeks ago

I've tested that markdown links in the [text](note) format works on my end too, is the markdown link that you're testing with valid?

It works now. Might have been an issue on my end. Sorry for the late reply, my account was hacked and I forgot about this after I regained access.

I'd close the issue, but I don't know if the previous comment is related or not