Allow customisation of popover background

[Riven53]

When the popup for definition appears it gets mixed with the text behind it like this

It only appears properly if the place behind it has a picture or is empty and works normally

This makes it difficult to use when studying because it is always overlapping

But it is still a great plugin.

[dominiclet]

This is likely due to the theme you're using, which set the background color to one that is transparent. I guess I can add an option to easily customise the background colour of the popover, but in the meantime, you can solve this by amending the "definition-popover" CSS class.

[Riven53]

I use the default theme as of now, what value should I give the definition-popover class (I'm not very good with css)

On Thu, Jul 18, 2024, 9:23 PM dominiclet @.***> wrote:

This is likely due to the theme you're using, which set the background color to one that is transparent. I guess I can add an option to easily customise the background colour of the popover, but in the meantime, you can solve this by amending the "definition-popover" CSS class.

— Reply to this email directly, view it on GitHub https://github.com/dominiclet/obsidian-note-definitions/issues/67#issuecomment-2236914835, or unsubscribe https://github.com/notifications/unsubscribe-auth/APR7SOG7FHBJQSIP6GY66T3ZM7QH5AVCNFSM6AAAAABLAVFXFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZWHEYTIOBTGU . You are receiving this because you authored the thread.Message ID: @.***>

[dominiclet]

From the root of your vault, you should see a hidden folder .obsidian. Enter the folder .obsidian/plugins/note-definitions, where you will see the files related to this plugin. You should see a css file styles.css among them. Open it and find the .definition-popover class. You want to overwrite the background-color property, which currently should hold a value of var(--background-secondary). Replace this with any colour you want. For more info on the values you can set you can refer to this https://developer.mozilla.org/en-US/docs/Web/CSS/background-color

[Riven53]

I changed it to black and the issue is still there

There is no difference even after changing it

This is what I changed

[dominiclet]

Have you restarted obsidian after changing it?

[Riven53]

I did not, but after restarting the plugin stopped working. It isn't underlining the text and clicking also does not work.

[dominiclet]

hmm, I'm not sure why that is happening, but for now just do a clean delete and reinstall of the plugin I guess. I'll add a customisation option for the color so you won't have to mess around with the css.

[dominiclet]

I've added a customisation option for the popover background colour in 0.24.0, hope it helps.