The CCCC implementation had the very final step missing

dominicprice / endplay

A suite of tools for generation and analysis of bridge deals. Read the documentation at https://endplay.readthedocs.io

MIT License

22 stars 5 forks source link

The CCCC implementation had the very final step missing #33

Closed EmanuelU closed 10 months ago

EmanuelU commented 10 months ago

http://www.rpbridge.net/8j19.htm

Based on this implementation, it reads at the very end

"Finally, add all four suit totals and subtract 1, then if 4-3-3-3 add 0.5"

This step was missed and therefore is evaluating all hands incorrectly

dominicprice commented 10 months ago

Oops - good spot! I’ll check the tests when I get home from work and merge. Thanks for contributing!

EmanuelU commented 10 months ago

Oops - good spot! I’ll check the tests when I get home from work and merge. Thanks for contributing!

No worries 👍 We use this package for some features in Cuebids, and one of our users pointed out the error, since I was not aware of the CCCC method to begin with, I had to do some debugging but seems like an easy fix at least :)

dominicprice commented 10 months ago

okay just added the test cases, LGTM :+1: