dominicstop / react-native-ios-context-menu

A react-native component to use context menu's (UIMenu) on iOS 13/14+
MIT License
544 stars 25 forks source link

Remote images #55

Closed nandorojo closed 2 years ago

nandorojo commented 2 years ago

@dominicstop is there a way to use remote images from a URL? I know we can use resolveAssetSource for local images, but it would be cool to have an API for remote images too if possible.

dominicstop commented 2 years ago

afahgsjdhdkfjdk maybe there's some way i can reuse RCTImage's remote image loading logic?

i'll look into it, and update this issue

dominicstop commented 2 years ago

Did some initial testing, and it should be doable asfdghsjdkls;gdfskfks

Screen Shot 2022-09-26 at 2 50 07 AM

i'll close this issue once i've fully implemented it

nandorojo commented 2 years ago

awesome!!

dominicstop commented 2 years ago

Hi, i've impl. this in the latest release (i.e. version 1.13.0), so i'll be closing the issue now asdfgvhdsfjsdbjksvfhewfw

i haven't added the documentation yet, so please refer to ContextMenuViewExample26 for now ✨

https://user-images.githubusercontent.com/18517029/192527402-1dd82c7f-2635-407d-b3da-18ac92340616.mp4

nandorojo commented 2 years ago

Wow amazing work, thanks for doing this so quickly.