Bugs

[x] Pressables inside of a context menu firing navigation in a native stack cause a crash
[x] Auxiliary view isn't pressable #66
[x] Sometimes dismissMenu doesn't work (unpredictably) but this is from v1. Not sure if this is still a problem on v2 or not.

Breaking Changes

[x] Automatically map v1 auxiliary props to v2 native auxiliary props to avoid breaking changes.

dominicstop commented 1 year ago

Current working on:

Item: 01 - Pressables inside of a context menu firing navigation in a native stack cause a crash
Branch: fix-issue#77-01 - compare changes - merge status

nandorojo commented 1 year ago

Great! Be sure to make the pressable navigate to another screen in a react navigation native stack.

Also let's add a test case with a text node deeply nested inside of the context menu view.

dominicstop commented 1 year ago

Item: 01 - Pressables inside of a context menu firing navigation in a native stack cause a crash
Branch: fix-issue#77-01 - compare changes
Status: Fixed (merged to main + published: patch 2.0.1)

dominicstop commented 1 year ago

Currently working on: item-02 - Auxiliary view isn't pressable https://github.com/dominicstop/react-native-ios-context-menu/issues/73
Branch: fix-issue#77–02 - compare changes
Status:
- 2023-11-03-02-57 - Debugging
- 2023-11-03-03-03 - Bug w/ react-native-ios-utiltiies + RNIDetachedView - Detached view not receiving touch events, because RCTTouchHandler has not been setup/initialized
- 2023-11-03-11-54 - Released: react-native-ios-utilities - minor - (4.1.0)
- 2023-11-03-12-00 - Released: react-native-ios-context-menu - patch (2.0.4)
- 2023-11-03-12-04 - Branch: fix-issue#77–02 - Merged to main
Status: Fixed - Checked via: Test03Screen

nandorojo commented 1 year ago

@dominicstop Regarding #73, I think that issue was caused by Zeego. I just removed it from FlashList and I'm no longer facing #73.

Could we try to fix #66 instead? I believe this issue got added from v2.

dominicstop commented 1 year ago

Currently working on: item-03 - Sometimes dismissMenu doesn't work (unpredictably) but this is from v1. Not sure if this is still a problem on v2 or not.
Branch: fix-issue#77–03 - compare changes - merge status
Status:
- 2023-11-03-12-31 - Debugging: Confirmed via ContextMenuViewTest08 - Occurs when navigation to a new screen, and going back.
- 2023-11-03-12-36 - Debugging: dismissMenu is being received from ContextMenuViewTest08 -> ContextMenuView.dismissMenu -> RNIContextMenuView.dismissMenu -> RNIContextMenuViewModule.dismissMenu
- reactTag is set, and promise resolves with no error.
- Maybe reactTag is stale? What is happening in the native side?
- 2023-11-04-01-46 - Debugging: dismissMenu command is received from the native side, however the contextMenuInteraction became nil for some reason?
- isContextMenuVisible is true, and window is not nil
- didTriggerCleanup is true - Maybe cleanup routine was triggered when a new vc was pushed...
- 2023-11-04-01-54 - Debugging: cleanup was being triggered via didMoveToWindow VC lifecycle, even though cleanupMode was set to reactComponentWillUnmount.
- 2023-11-04-02-37 - Released: patch (2.0.5)
- 2023-11-04-02-39 - Merged to main

dominicstop commented 1 year ago

Currently working on: item-04: Features - Explore double-tap to open a reaction like iMessage's "Tapback" feature
Branch: TBA

2023-11-05-06-49 - Tried using UIButton + UIMenu - Works but buggy + you can't open the context menu programmatically
2023-11-05-08-15 - Trying to figure out if there's a way to programmatically show the context menu without resorting to synthesizing a "fake" UITouch touch event and feeding it into a view.
- Looking through UIContextMenuInteraction disassembly if there's something we can invoke to show the context menu...
- _requestSceneActivationWithConfiguration:animated:sender:errorHandler:
- _willBeginWithConfiguration: - no-op/ret
- _presentMenuAtLocation: - calls: _presentMenuAtLocation3D

2023-11-05-11-33 - Invoking _presentMenuAtLocation shows the context menu
- Added Experiment02ViewController - Initial code to test for invoking _presentMenuAtLocation
- Impl. ContextMenuInteractionWrapper.presentMenuAtLocation to programmatically show the context menu.
- Updated Experiment02ViewController to use ContextMenuInteractionWrapper.

2023-11-06-14-37 - Ran into a blocker with attaching an aux. preview to UIButton context menus
- In order to attach the aux. preview, we need to get notified that the context menu is about to shown; we do this via the UIContextMenuInteractionDelegate
- UIButton becomes the delegate for the menu interaction, so we can't actually get notified that the context menu interaction is starting
2023-11-06-17-39 - Resorted to swizzling to intercept the UIContextMenuInteractionDelegate invocation
- Updated Experiment01ViewController - Impl. test/temp code to intercept UIContextMenuInteractionDelegate.contextMenuInteraction(_:willDisplayMenuFor:animator:) via swizzling.
- Uses SwizzlingHelpers.swizzleWithBlock
- Need to consolidate the swizzling logic to it's own type; maybe ContextMenuInteractionDelegateInterceptor?

focux commented 9 months ago

First, thank you for all the work you put into this lib, it's amazing.

Also, is there any progress on the double-tap feature?

nandorojo commented 9 months ago

Yes, the ref should have a present function now