search

dominictarr / JSONStream

rawStream.pipe(JSONStream.parse()).pipe(streamOfObjects)
Other
1.92k stars 165 forks source link

Clean test files? #120

Open sanjaykbhat opened 7 years ago

sanjaykbhat commented 7 years ago

The current test file : JSONStream\ test\ fixtures\ all_npm.json has profanity words: brainfuck, gang-bang etc. Do we really need these profanity words? Can we not remove them?

dominictarr commented 7 years ago

Well, I never intentionally put those words in, I just generated a test file from the modules on npm, where those modules are published. So, no, we don't need those "profanity" words, we just need file to test against.

https://www.npmjs.com/package/brainfuck is actually a real thing - it's an esoteric programming language with some interesting features, but I agree the gang-bang module name is in poor taste.

Why did this come to your attention? does your company have a script which searches their code & dependencies for profanity?

If you really want to, and make a pull request to remove them, I guess I'll merge it but this does seem rather unnecessary to me (especially considering that it's just in the tests, and won't get shipped to a client even if you browserify it)

syabro commented 7 years ago

@dominictarr it's some kind of troll, please have a look at his other request https://github.com/yapstudios/YapDatabase/issues/388

dominictarr commented 7 years ago

Normally trolls are doing it for fun! (aka "lulz") That I can understand. This particular "troll" doesn't seem that funny though

sanjaykbhat commented 7 years ago

Not a troll. Assure you that, my company is using this library and our code scanner picked this up hence posted it. Feel free to ignore me if this is feeling like SPAM :(.

On Feb 3, 2017 4:38 PM, "Dominic Tarr" notifications@github.com wrote:

Normally trolls are doing it for fun! (aka "lulz") That I can understand. This particular "troll" doesn't seem that funny though

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dominictarr/JSONStream/issues/120#issuecomment-277222307, or mute the thread https://github.com/notifications/unsubscribe-auth/AYTIK_HM8pL4VzQAKEsi4MhOkptiI77zks5rYwqWgaJpZM4LzuyM .

dominictarr commented 7 years ago

@sanjaykbhat what code scanner do you use?

sanjaykbhat commented 7 years ago

It is an internal built tool.

On Feb 5, 2017 4:41 AM, "Dominic Tarr" notifications@github.com wrote:

@sanjaykbhat https://github.com/sanjaykbhat what code scanner do you use?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dominictarr/JSONStream/issues/120#issuecomment-277485021, or mute the thread https://github.com/notifications/unsubscribe-auth/AYTIKwN5DWtWQOPPmxwI0-6qA6FmddW2ks5rZQWYgaJpZM4LzuyM .

dominictarr commented 7 years ago

so - you are asking me to change my open source software because of an mostly imagined problem created by a internal tool that isn't even open source. If your script was open source I might consider it (the open source street runs both ways! - tell your boss!)

Though, I imagine in many companies simply publishing a thing as open source isn't simply allowed, unfortunately. If this is the case for you, I might suggest updating the script to simply delete the files that contain the "offensive" words. Since in this case, it's just test files in your dependencies, it's not gonna break anything.