Closed daern91 closed 6 years ago
@mfogel looks like this change will break your code?
@dominictarr yeah I think so. This would re-open #148
Seems that it should be possible to fix this memory leak issue without re-breaking the double-dot operator.
My bad, I missed the earlier issue. Anyways, thanks guys, @dominictarr and @mfogel. Updated the PR now to fix memory leak without reverting @mfogel's fixes.
Any update here @dominictarr?
It would be nice to merge this PR :-)
@dominictarr @mfogel anything else you can see that is blocking this PR? Quite a few people that would appreciate a fix https://github.com/dominictarr/JSONStream/issues/153
As far as I can see, the PR now looks ok to me.
@daern91 hey, sorry for the delay. would you be willing to help maintain this module? I don't really even use it anymore, and have lots of other things to do with my time. I can add you and you can merge this
@dominictarr No problems at all, I don't have time for very active maintenance but can definitely read through PRs, fix smaller issues and merge as needed.
@daern91 there arn't many issues/PRs, it's just that I have loads of other stuff
@daern91 you can now merge and publish
PR reverts commits 2e4fcb and 8c1206 that introduced memory leaks.
Please squash merge.
resolves #153