dominictarr / JSONStream

rawStream.pipe(JSONStream.parse()).pipe(streamOfObjects)
Other
1.92k stars 165 forks source link

Ignore 'test' in npmignore #67

Closed zertosh closed 9 years ago

zertosh commented 9 years ago

Please consider excluding the "test" dir from the published package. They're 500k (granted not much), but packages like browserify include it about 5 times through its various dependencies.

zertosh commented 9 years ago

@dominictarr Can you publish 1.x to npm please? (https://github.com/dominictarr/JSONStream/compare/7ae00aa...a85a00a)

kenany commented 9 years ago

@zertosh https://github.com/dominictarr/JSONStream/issues/59

zertosh commented 9 years ago

Thanks @KenanY! I'll leave this open just for the npmignore change - for when it's possible to update

dominictarr commented 9 years ago

browserify does not include the tests in the bundle. I always leave the tests in my modules because one day it might be useful to be able to run all the tests from npm...