search

dominictarr / JSONStream

rawStream.pipe(JSONStream.parse()).pipe(streamOfObjects)
Other
1.92k stars 165 forks source link

Clarify licensing #71

Closed kemitchell closed 9 years ago

kemitchell commented 9 years ago

Kia ora, @dominictarr! Thanks so much for JSONStream.

This PR clarifies what I take it are the licensing terms for the package: "dual licensing" under MIT andor Apache 2.0, so users can pick between them. The commit also adds an appropriate package.json property for dual licensing.

Boolean license expressions, you say? Mad license science, says I!

dominictarr commented 9 years ago

In the package.json it says OR but in the readme it says AND. I'm not a laywer but it seems this should be consistent.

Can you find a big project that uses dual licencing and see how they phrase it?

kemitchell commented 9 years ago

A list of dual-licensed npm packages I dug up for the PR to npm:

https://github.com/npm/npm/pull/8179#issuecomment-98935152

I will have a look at their language and let you know. That being said, the definitions of AND and OR in the SPDX spec are more specific than common usage. The canonical example of AND is a package that links or packages another, say a library, that has a different license. The canonical case for OR is dual- or mult-licensing.

Thanks for your time. Given how many other packages depend on this one, I think sorting it out will save a lot of time.

kemitchell commented 9 years ago

I noticed also that your rc also currently uses slashes.

So it's a wash. I will amend to use "or", to make it consistent.

dominictarr commented 9 years ago

Oh, okay that changes everything, I know that some people need to use tools to check dependencies are compatible with their legal departments, so it's important to follow a standard, but I see you are taking the lead on this one, so I'll be happy to merge whatever you settle on.

kemitchell commented 9 years ago

If dual licensing is what you want, then 8c47818 does the job.

Thanks for your feedback on consistent terminology. Should save others some time, as I plan to follow up with all the popular dual-licensed, so they don't have to wade into the details of the new guidelines.

Would you like a PR in rc, as well?

dominictarr commented 9 years ago

sure, okay merging.

dominictarr commented 9 years ago

merged into 1.0.4

kemitchell commented 9 years ago

Thanks, @dominictarr! Really appreciate time spent on this.