dominictarr / bench-lru

MIT License
89 stars 11 forks source link

hyperlru package problem affects fresh installs with node 8.x #13

Closed avoidwork closed 7 years ago

avoidwork commented 7 years ago

@Kikobeats I noticed this morning that the should module isn't installed with your modules even though it's listed as latest, it appears to have a conflict with other requirements such that npm can't install it which results in this project being non-functional on a fresh clone/install/execution.

screen shot 2017-10-10 at 7 09 25 am

screen shot 2017-10-10 at 7 13 00 am

I'd wager it's that "5." vs "latest" that's creating the conflict for npm.

avoidwork commented 7 years ago

The package-lock.json created by npm is available at https://gist.github.com/avoidwork/94ca81710daed11265f080f3af3a83ba

Kikobeats commented 7 years ago

In your second screen I'm seeing * in simple-lru-cache, not hyperlru 🤔

* should be means latest, I think.

But this is more related with npm resolution.

avoidwork commented 7 years ago

That second window is just the default pop-up inside webstorm (any intelli-j based ide). It's confusing af for ops, because you gotta click that 'open in find window' in bottom right for it to persist. The UI has it's own issues 😂

avoidwork commented 7 years ago

imo, this is an npm bug, but i'm not sure how to approach it since it spans across multiple modules brought into this project for testing :/

Kikobeats commented 7 years ago

Actually should dependency inside hyperlru package is not necessary; I release a new patch version removing it, but I suppose this bug need to be reported at npm repository 👍

avoidwork commented 7 years ago

cool, i shall report it

dominictarr commented 7 years ago

yuk, you should not use * module ranges, that is asking for trouble. Anyway, I think these shouldn't be installed anyway because they are dev deps, unless you clone those repos and then install directly.

avoidwork commented 7 years ago

Created https://github.com/npm/npm/issues/18784