search

dominictarr / crdt

Commutative Replicated Data Types for easy collaborative/distributed systems.
MIT License
836 stars 43 forks source link

Emit `remove` on a row when it's removed #32

Closed mmalecki closed 10 years ago

dominictarr commented 10 years ago

does this resolve https://github.com/dominictarr/crdt/issues/30 ?

I know this seems obvious enough, but can you include a description as to the reason for the change, so I know how you are using it?

As a module author, you get very little feedback as to what your modules are actually being used for, and how they are being used.

I think maybe the row should emit 'removed', since set already has a 'remove' event, that has the row as arguments.

mmalecki commented 10 years ago

It kind of solves #30.

I was going to use it in knockout-crdt-observable-array to avoid doing this.

removed indeed sounds better. I'll amend and push.

dominictarr commented 10 years ago

cool, this is merged into 3.6.0 !

mmalecki commented 10 years ago

awesome, thanks!