dominictarr / feedopensource

Iteratively Fund Open Source Projects With Bitcoin
feedopensource.com
MIT License
142 stars 16 forks source link

incorrect query syntax causes api to return 404 status when not using client auth. #45

Closed joates closed 10 years ago

joates commented 10 years ago

should always use client auth but since it is possible to not use any auth, need to check for this.

curl 'https://api.github.com/repos/dominictarr/feedopensource/collaborators&per_page=100'
{
  "message": "Not Found",
  "documentation_url": "http://developer.github.com/v3"
}
joates commented 10 years ago

enable override default host with config setting.

there may be a cleaner way to inject the config.host setting into the RegExp than this.. (but it works and it makes it easier for me to continue QA testing).

joates commented 10 years ago

[bugfix] open tasks are counted as completed tasks (incorrectly)

tested -> here

joates commented 10 years ago

tested -> here

the link shows that it does work without escaping (the caveat is that it must be the final character in the group)

althought if it is explicitly escaped then the hyphen can be anywhere in the group and it will not be interpreted as part of a range.

dominictarr commented 10 years ago

ah, okay. better to escape it I think.

dominictarr commented 10 years ago

this is fixed now.