search

dominictarr / level-live-stream

MIT License
80 stars 11 forks source link

Update sublevel #18

Closed dey-dey closed 10 years ago

dominictarr commented 10 years ago

Okay i've updated the level-sublevel version, but i didn't merge this because your patch also changed the version number, which should have been a patch. Why did you do this? was it to bust npm's cache?

Btw, generally you should not change a version bump in a pull request, that is the maintainer's responsibility. Personally, I like to have a commit that just changes the version number, so that it's easy to reconcile npm versions to git commits. (npm has a handy command to do this: npm version [patch minor major])

use level-live-stream@1.4.10

dey-dey commented 10 years ago

Cool thanks for the info, wasn't sure about protocol with version updates :/

Thanks again!