search

dominictarr / mynosql

MIT License
44 stars 5 forks source link

sub sublevels? #4

Open pfrazee opened 9 years ago

pfrazee commented 9 years ago

Hey, I'm wondering if using sublevels (log, meta) directly off the received db could result name collisions. SSB uses a log sublevel.

Could they go in a 'mynosql' sublevel? db.sublevel('mynosql').sublevel('log')?

juliangruber commented 9 years ago

you should be able to pass db.sublevel('mynosql') to this module, to avoid conflicts

pfrazee commented 9 years ago

@juliangruber if you did that, would the indexing in https://github.com/dominictarr/mynosql/blob/master/index.js#L40 catch everything on the db, or would it only catch data added to the mynosql sublevel?

pfrazee commented 9 years ago

hm, the proposed merge of mynosql with ssb puts the log sublevel into mynosql's hands https://github.com/ssbc/secure-scuttlebutt/pull/95/files#diff-168726dbe96b3ce427e7fedce31bb0bcR96

dominictarr commented 9 years ago

@pfraze yes I log sublevels use contain exactly the same data in these cases.

pfrazee commented 9 years ago

ok, that's fine then. Might want to document the sublevel use in the readme

dominictarr commented 9 years ago

@pfraze the mynosql readme?

pfrazee commented 9 years ago

@dominictarr yeah

dominictarr commented 9 years ago

fixed in 2.2.1 (i mean, i documented it)

pfrazee commented 9 years ago

:+1:

NHQ commented 9 years ago

BTW level-sublevel was not added to the pkg.json