search

dominictarr / npmd

MIT License
450 stars 37 forks source link

use medeadown instead of leveldown #76

Closed kesla closed 10 years ago

kesla commented 10 years ago

Hey, so here's what I suggested before.

Question - how would you like to do with the folder? Should it be renamed to something else?

kesla commented 10 years ago

Yo,

I've used npmd with medeadown now for a couple of days since yesterday - and it has worked out great!

npmd weren't closing the db when it had finished, which meant that some of the cleanup that exists in medeadown wasn't run, but other than that I've had no issues.

dominictarr commented 10 years ago

okay cool, but we should change line 33 because the jsdb option is no longer being used, hmm, and probably a small script to migrate the data from the old database, the first time at least.

can leveldb and medea use the same directory without complaining?

kesla commented 10 years ago

Yeah, they can live in the same folder

The problem with doing a migration is that you'll then still have a compiled dependency?

Wouldn't it be enough to do a cleanup of the old leveldb-files on install, and then up the major version of npmd?

dominictarr commented 10 years ago

yes - I think the best approach is to have a transition version, or a separate tool that does the migration.

duralog commented 10 years ago

I'd really like to see this go through - solely because I have npmd installed globally and I always forget, so I get this sweet error

$ npmd install
/usr/local/lib/node_modules/npmd/node_modules/leveldown/node_modules/bindings/bindings.js:83
        throw e
              ^
Error: Module did not self-register.
    at Error (native)
    at Module.load (module.js:349:32)
    at Function.Module._load (module.js:305:12)
    at Module.require (module.js:357:17)
    at require (module.js:373:17)
    at bindings (/usr/local/lib/node_modules/npmd/node_modules/leveldown/node_modules/bindings/bindings.js:76:44)
    at Object.<anonymous> (/usr/local/lib/node_modules/npmd/node_modules/leveldown/index.js:1:99)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:349:32)
    at Function.Module._load (module.js:305:12)

so, I open up this page and check this issue and #75 - and see nothing has happened yet.

I have a solution: I'd more than love to write the transition tool as we discussed in the other issues - if that's what's holding things up (or if you haven't even started on it)... let me know before the weekend is over, heheh :) - though, I can probably still power through it on mon/tue night.

in the other issue you suggested nedb... I'm not aware if medea works on windows or not, however it should. if you wanna do nedb or some sort of configurable *down db, I'd love to write that as well, and I can be sure to copy the mad science syntax you use, too. just let me know what to do, and it's done

cheers

dominictarr commented 10 years ago

okay this is merged into 1.3.2