search

dominictarr / npmd

MIT License
450 stars 37 forks source link

adding engines>=0.9.0 for setImmediate() support #9

Closed selfcontained closed 11 years ago

selfcontained commented 11 years ago

Need at least node 0.9.0 to run npmd because of setImmediate().

Adding engines >= 0.9.0

dominictarr commented 11 years ago

hmm, I'd rather make a patch that made it work in 0.8, can you post the error message?

dominictarr commented 11 years ago

I think this should be fixed, can you reinstall and test again?

selfcontained commented 11 years ago

Made it past the setImmediate() error, but failed on this now. Looks like there's a reference to osenv instead of the variable os in npmd-install - https://github.com/dominictarr/npmd-install/blob/master/index.js#L5

/usr/local/lib/node_modules/npmd/node_modules/npmd-install/index.js:22
  var tmpdir = osenv.tmpdir()
               ^
ReferenceError: osenv is not defined
    at module.exports (/usr/local/lib/node_modules/npmd/node_modules/npmd-install/index.js:22:16)
    at /usr/local/lib/node_modules/npmd/index.js:37:28
    at loadCbs.length (/usr/local/lib/node_modules/npmd/node_modules/npmconf/npmconf.js:76:7)
    at Array.forEach (native)
    at /usr/local/lib/node_modules/npmd/node_modules/npmconf/npmconf.js:75:13
    at /usr/local/lib/node_modules/npmd/node_modules/npmconf/node_modules/once/once.js:17:15
    at Conf.<anonymous> (/usr/local/lib/node_modules/npmd/node_modules/npmconf/npmconf.js:117:9)
    at Conf.g (events.js:192:14)
    at Conf.EventEmitter.emit (events.js:96:17)
    at ConfigChain._resolve (/usr/local/lib/node_modules/npmd/node_modules/npmconf/node_modules/config-chain/index.js:281:34)
dominictarr commented 11 years ago

oops, my bad.

fixed, just reinstall so you get npmd-install@3.0.5

selfcontained commented 11 years ago

works like a charm now, thanks.