remove duplicate declaration

dominictarr / scuttlebutt

peer-to-peer replicatable data structure

Other

1.32k stars 66 forks source link

remove duplicate declaration #26

Closed aeosynth closed 11 years ago

aeosynth commented 11 years ago

why are you even writing emit.call(this, ...) instead of this.emit(...)?

edit: instead of this.setMaxListeners(Number.MAX_VALUE), you could use this.setMaxListeners(0) for unlimited listeners, although your solution is technically more robust

dominictarr commented 11 years ago

It's because some scuttlebutts overwrite emit and this guarantees that the correct emit is called. I think there is probably a test for this, did you run the tests?

aeosynth commented 11 years ago

all tests pass. the removed statement is duplicated on line 54 of master; this commit has no functional effect

dominictarr commented 11 years ago

Ah, very good. Merging.