dominictarr / split

MIT License
347 stars 39 forks source link

test for problem with partitioned unicode characters added #6

Closed mkronschnabl closed 10 years ago

mkronschnabl commented 10 years ago

I have added a test with a partitioned unicode character, which should show the problematic behaviour.

dominictarr commented 10 years ago

cool, thanks!

Okay, this is fixed in 0.2.7 !

mkronschnabl commented 10 years ago

Thanks a lot!

Unfortunately we still have a problem as we use Node 0.8.22 and in this version there is no function StringDecoder.end().

We plan to update Node but for now we have to remove the line

next(this, decoder.end())

Then it works perfectly for us.

dominictarr commented 10 years ago

Ah okay, interesting,

I've updated it to only call that line when there decoder has end, also, added travis hook so it will test on 0.8 and 0.10

dominictarr commented 10 years ago

fixed in 0.2.10

mkronschnabl commented 10 years ago

Thanks again!