search

dominictarr / through

simple way to create a ReadableWritable stream that works
Other
669 stars 64 forks source link

Fix non-strict null check #32

Closed jarofghosts closed 9 years ago

jarofghosts commented 9 years ago

Because of the == check vs. ===, undefined was causing _ended to be flagged (and consequently no further data events to be emitted), without actually emitting any kind of end event, which lead to some surprises.

dominictarr commented 9 years ago

through is so stable and changes so little these days, that I was worried that I should consider this a breaking change, but I checked the code, and I saw that there is another place that checks null with ===, so this is definately a bug. merging.

dominictarr commented 9 years ago

merged into 2.3.7