search

dominictarr / xdiff

diff complex javascript objects
Other
71 stars 10 forks source link

reconsider project naming.. #1

Open jeske opened 11 years ago

jeske commented 11 years ago

Thanks for writing adiff and xdiff... I add this note with the utmost of respect and apprectiation for your work here.

It's a bit odd that the "adiff" project is actually close to (or exactly) an implemention of the somewhat well known "xdiff" algorithm used in Git, and your "xdiff" project is actually a "javascript tree diff" tool using "adiff".

http://mail.xmailserver.net/xdfs.pdf http://www.xmailserver.org/xdiff-lib.html

For the sake of people understanding what exists here, you might consider renaming "adiff" to "xdiff" or "js-xdiff", and renaming "xdiff" to "js-tree-diff"

dominictarr commented 11 years ago

Oh, that is unfortunate. I was not aware of xdiff.

I intended adiff to refer to "Array" and "x" to refer to Anything, as in a variable. I am reluctant to rename, but I will link to that that documentation, and clearly mention that what you may be looking for is adiff.

I'll leave this issue open, and if other people agree I'll consider renaming.