search

dominik-th / matomo-plugin-LoginOIDC

external authentication services for matomo
https://plugins.matomo.org/LoginOIDC/
GNU General Public License v3.0
40 stars 29 forks source link

Add an internal URL setting for OIDC servers behind the same reverse proxy #113

Open fschuermeyer opened 3 months ago

fschuermeyer commented 3 months ago

A new setting for the internal URL has been added in this pull request. This setting is useful if the OIDC provider runs behind the same reverse proxy as Matomo. In such cases, it may be necessary to specify the internal URL of the OIDC provider in order to correctly route internal cURL requests.

The changes include:

  1. Adding a new setting internalUrl in the LoginOIDC plugin. This setting allows the user to specify the internal URL of the OIDC provider.
  2. Changing the tokenUrl and userinfoUrl settings to include the internalUrl if it is set. If the internalUrl is set, the tokenUrl and userinfoUrl will be changed to use the internalUrl's scheme, host and port.
  3. Add translations for the internalUrl setting in the language files.

These changes should make it easier for Matomo users who use an OIDC provider behind the same reverse proxy to set up their configuration correctly.

I look forward to any feedback. Please let me know if there are any additional adjustments I should make to meet your requirements.

fschuermeyer commented 3 months ago

image Settings Example

fschuermeyer commented 1 month ago

@dominik-th any updates?