search

dominik-th / matomo-plugin-LoginOIDC

external authentication services for matomo
https://plugins.matomo.org/LoginOIDC/
GNU General Public License v3.0
42 stars 30 forks source link

Fix user settings render in 4.x-dev branch #19

Closed dominik-th closed 3 years ago

dominik-th commented 4 years ago

Matomo reorganized some of the personal settings. There is an additional "Security" category, which fits best for the LoginOIDC settings:

https://github.com/dominik-th/matomo-plugin-LoginOIDC/blob/master/LoginOIDC.php#L29

    public function registerEvents() : array
    {
        return array(
            "AssetManager.getStylesheetFiles" => "getStylesheetFiles",
            "Template.userSettings.afterTokenAuth" => "renderLoginOIDCUserSettings",
            "Template.loginNav" => "renderLoginOIDCMod"
        );
    }

should be changed to

    public function registerEvents() : array
    {
        return array(
            "AssetManager.getStylesheetFiles" => "getStylesheetFiles",
            "Template.userSecurity.afterPassword" => "renderLoginOIDCUserSettings",
            "Template.loginNav" => "renderLoginOIDCMod"
        );
    }

but it should also keep backwards compatibility.

dominik-th commented 3 years ago

Fixed in 4.x-dev branch. Option to link OIDC account is now under the users security settings