search

dominik-th / matomo-plugin-LoginOIDC

external authentication services for matomo
https://plugins.matomo.org/LoginOIDC/
GNU General Public License v3.0
42 stars 30 forks source link

Update LoginOIDC.php #39

Closed ghost closed 3 years ago

ghost commented 3 years ago

LoginOIDC table needs to be the same character set as Matomo in order to join on user. Matomo default charset is utf8. Some databases do not have utf8 set as the default.

dominik-th commented 3 years ago

Thanks for your PR Unfortunately you can't just set the charset to UTF-8 as we can't assume the other tables are UTF-8 encoded.

ghost commented 3 years ago

Correct. In Matomo 3.x.x the charset was hardcoded. https://github.com/matomo-org/matomo/blob/3.x-dev/core/Db/Schema/Mysql.php In Matomo 4.x.x the charset is configurable. https://github.com/matomo-org/matomo/blob/4.x-dev/core/Db/Schema/Mysql.php