search

dominik-th / matomo-plugin-LoginOIDC

external authentication services for matomo
https://plugins.matomo.org/LoginOIDC/
GNU General Public License v3.0
42 stars 30 forks source link

Feature: Auto linking of accounts #45

Closed ghost closed 3 years ago

ghost commented 3 years ago

fixes #44

dlecan commented 3 years ago

This feature is very interesting!

  1. I can provide French translations
  2. Is it possible to customize the OIDC field used to match internal/external user?
  3. is it possible to disable password authentication at all?
ghost commented 3 years ago

@dlecan

ad 1: yes please ad 2: I hope I understood it correct, but I guess you can change the "userinfoId"-setting (https://github.com/dominik-th/matomo-plugin-LoginOIDC/blob/4.x-dev/SystemSettings.php#L89) ad 3: I currently found no way to do that.

pschichtel commented 3 years ago

@dominik-th anything blocking this?

Bengrunt commented 3 years ago

That would be great to have this feature :)

ghost commented 3 years ago

Is there anything I can do to help with reviewing / evaluating this PR?

dominik-th commented 3 years ago

Hi!

Thank you for your PR!

Sorry about the delay, I am going to review and merge it this weekend!

ghost commented 3 years ago

I put the changes in one commit and hope that I haven't missed anything?

ghost commented 3 years ago

Have I missed something?

dominik-th commented 3 years ago

No, looks good! I'm going to test merge and release a new version next weekend