Improvements - Githubissues

dominikberse / homeassistant-bluetooth-mesh

Allows to use bluetooth mesh devices directly from homeassistant

61 stars 15 forks source link

Closed Minims closed 1 year ago

Minims commented 1 year ago

@dominikberse I have add a brightness_factor for Now + some linting / formatting on the code. Tell me if you prefer something else.

WIP, I need a bit more testing before to be sure I have no broken something else.

dominikberse commented 1 year ago

Thanks for the contribution. I like the idea of having a config.yaml.sample file and using a linter.

Some thoughts I had:

I think I would prefer a solution to set a range for brightness and color temperature. This seems a little more flexible and reusable (although of course for the brightness I would say min is always 0).
Would be nice to have some config file for (auto-)linting
Before merging you need to reset the repo in the Dockerfile, but I just noticed that I forgot this too :D

Minims commented 1 year ago

Ok, I will make separate PR for an easier review.