Open CharlesWinter opened 3 years ago
Wow, thanks a lot for this massive feature! I'm just going to release timetrace v0.11.1 today and review and merge some PRs in the pipeline for timetrace v0.12.0 - then I'll be able to take a closer look at the push command.
Hey @CharlesWinter, is this ready to be reviewed? :-)
Hi @dominikbraun it's definitely missing some tests, so I don't think it's ready for merge yet.
But I think the implementation isn't likely to change so if you want to take a look I would welcome it!
Adds a "push" command that will push your timetrace records for that day to a remote system (JIRA in this PR).
This PR is still a draft. I've thrown caution to the wind and have exactly zero tests for what I've done, as I started this work just for fun. Please don't merge it yet until there are tests. The purpose of the PR is simply to make you guys aware that I've been working on this, and to of course allow others to improve upon it as they see fit. As it stands the code does work, and records are pushed where timetrace sees fit, and are pushed only once. It of course also needs a readme entry on how to actually set it up.
How does it work? (see the GIF for a demo)
tw-20@timetrace
ortw-2
would be pushed totw-20
andtw-2
respectively. B. The record has not been pushed before.timetrace_record_id: "2020-10-20T10:32:00"
. It seems timetrace uses the startdate as a unique ID for a record so I thought I would continue the convention in JIRA. This metadata is added so a record can only be pushed once.Technical Considerations for Reviewers
To conclude, still early days for this PR, as it started mainly for my own enjoyment and the code needs some love/tests/rebasing to get it in :) I'll continue working on it when I get time.
Contributions welcome.