search

dominikbraun / timetrace

A simple CLI for tracking your working time.
Apache License 2.0
668 stars 75 forks source link

Check record collisions before editing a record #191

Closed amoghrajesh closed 2 years ago

amoghrajesh commented 2 years ago

This PR adds a fix to check if a time collision happens before enabling editing the record. Fixes #187

amoghrajesh commented 2 years ago

@dominikbraun I have handled the changes in the issue. Please review it.

amoghrajesh commented 2 years ago

Thanks @dominikbraun for the +1. Could you merge it or label it so that it gets counted for as an Hacktoberfest PR for me?

dominikbraun commented 2 years ago

@amoghrajesh Shouldn't my approval be enough (see guidelines)? But I'm going to merge these PRs very soon anyway.

amoghrajesh commented 2 years ago

@dominikbraun yes, looks that should suffice, but you can add a 'hacktoberfest-accepted' label just to be sure it counts. Thanks!