search

dominikbraun / timetrace

A simple CLI for tracking your working time.
Apache License 2.0
700 stars 76 forks source link

12 hour format does not differentiate between AM and PM #55

Closed joshuaherrera closed 3 years ago

joshuaherrera commented 3 years ago

Hi, In working on issue #17 in version 0.4.0, I noticed that, when 12 hour time format is configured with config.yaml, one must always pass in the PM portion of the flag, even if the time logged was in the AM, as shown.

timetrace-time-format

It seems to me the command should allow for the user to input AM or PM, or perhaps allow the user to omit the PM entirely, with the assumption that any time entered without PM is assumed to have been logged in the AM. Thoughts?

joshuaherrera commented 3 years ago

Hi @dominikbraun, I'd like to take on this issue.

joshuaherrera commented 3 years ago

@dominikbraun After looking into it, this was user error on my part. When testing with AM time, I changed the values within the "start" and "end" keys under $HOME/.timetrace/records/2021-05-20, but I did not change the .json filename, since I did not realize the name of the file was how the records were retrieved. Apologies!

dominikbraun commented 3 years ago

Nevermind, #51 will implement the timetrace edit record command for that cases.