search

dominikbraun / timetrace

A simple CLI for tracking your working time.
Apache License 2.0
679 stars 75 forks source link

Report issue#88 #99

Closed KonstantinGasser closed 3 years ago

KonstantinGasser commented 3 years ago

This is a first proposal for the report command. Supported flags:

The command is designed the way it is discussed in #88.

In the cli/report.go I commented TODOs. Here I would be happy to get some input as I don't like the way I have implemented the checks if a Flags.StringVarP has its default value...

KonstantinGasser commented 3 years ago

@dominikbraun while using the report feature my self I found a bug causing a panic if --start or --end where given.. I have fixed that bug and appended it to this PR. I also fixed another bug where the --end time would not be inclusive.

dominikbraun commented 3 years ago

Thanks! Is this ready to review already?

KonstantinGasser commented 3 years ago

Yes it is ready to be reviewed - all of the above mentioned flags are supported (only serialisation to csv is not implemented yet)

KonstantinGasser commented 3 years ago

@dominikbraun I noticed a merge conflict for this PR after the latest release - I fixed that one PR is ok again.

KonstantinGasser commented 3 years ago

@dominikbraun I have Uni until 6pm I will implement your changes afterwards and update the PR 👍

KonstantinGasser commented 3 years ago

I have incorporated your suggestions and updated the PR

KonstantinGasser commented 3 years ago

Cool, great to hear!