search

dominikg / tsconfck

A utility to find and parse tsconfig files without depending on typescript
Other
290 stars 14 forks source link

Fix typescript 5.5 parse for configDir #179

Closed lPernod-sorare closed 2 months ago

lPernod-sorare commented 2 months ago

This builds on #178 and fixes differences between parse and parseNative for configDir for typescript 5.5

lPernod-sorare commented 2 months ago

Tests are broken on windows due to wrong implementation of #178, I'll fix there and rebase this on that

dominikg commented 2 months ago

thank you so much. You'll also have to run pnpm generate and pnpm changeset to update generated files and create a changeset.

If you are ok with it i'll push an extra testcase to ensure it doesn't regress and improve the ts 5.5 logic a bit.

dominikg commented 2 months ago

done, i did shorten the baseUrl implementation a bit and made it resilient for future tokens apart from configDir (although these need to be added to replaceTokens then).

dominikg commented 2 months ago

Thanks a lot for catching this @lPernod-sorare ! it will be released with the next vite patch too.

dominikg commented 2 months ago

released in vite 5.3.2 https://github.com/vitejs/vite/blob/v5.3.2/packages/vite/CHANGELOG.md