Missing functions - Githubissues

dominikh / go-augeas

Go bindings for augeas

MIT License

21 stars 7 forks source link

Missing functions #3

Open dominikh opened 8 years ago

dominikh commented 8 years ago

The following Augeas functions aren't currently implemented and should probably be added:

[x] aug_label
[ ] aug_cp
[ ] aug_rename
[ ] aug_text_store
[ ] aug_text_retrieve
[ ] aug_escape_name
[x] aug_transform
[ ] aug_srun

Looking for volunteers to contribute those functions.

raphink commented 8 years ago

I'd love to have Srun right now :wink:

raphink commented 8 years ago

@dominikh I just wrote https://github.com/raphink/go-augeas/commit/13670f8d56e63c69e4bbef7a1aaadecbff4fcf19 but I can't build it, go doesn't seem to find pkg-config info:

$  go tool cgo augeas.go 
In file included from /home/rpinson/go/src/github.com/raphink/go-augeas/augeas.go:8:0:
/usr/include/augeas.h:24:25: fatal error: libxml/tree.h: No such file or directory
compilation terminated.

dominikh commented 8 years ago

@raphink Is there a reason you're invoking go tool cgo directly? That's an internal tool used by go build, and will expect certain flags. The pkg-config logic is handled elsewhere as far as I know.

raphink commented 8 years ago

go build has another issue...

can't load package: package github.com/raphink/go-augeas: code in directory /home/rpinson/go/src/github.com/raphink/go-augeas expects import "honnef.co/go/augeas"

I'm still not really sure about the best way to do PRs on Go projects, since they explicitely declare online dependencies.

dominikh commented 8 years ago

Give http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html a read.

raphink commented 8 years ago

Interesting, thanks.

raphink commented 8 years ago

So I managed to get it to build... But I'm stuck with this IO_FILE object now... https://github.com/raphink/go-augeas/blob/srun/augeas.go#L211 any clue?