search

dominikh / go-js-dom

MIT License
252 stars 42 forks source link

Implement window.GetComputedStyle #11

Closed andrebq closed 10 years ago

dominikh commented 10 years ago

Looking at https://developer.mozilla.org/en/docs/Web/API/window.getComputedStyle again, we should probably add the "pseudoElt" argument as well, with "" mapping to null. Apart from that, the change looks good.

andrebq commented 10 years ago

Any news about this?

dominikh commented 10 years ago

I don't get notifications when commits are added to PRs unless someone also comments on it, so I wasn't aware that you addressed my request yet, sorry about that.

The change looks good to me and I'll apply it once I get the chance. Thanks.

dominikh commented 10 years ago

Merged as 1b312d5..6da85e8, thank you.