Closed josedonizetti closed 10 years ago
Thanks.
A number of stylistic issues first:
// comment here
, not //comment here
Instead of writing
if maxWidth == -1 {
something()
} else {
somethingElse()
}
write
if maxWidth == -1 {
something()
return
}
somethingElse()
That's as far as global stylistic issues go. Notes to specific lines will follow as inline comments.
Please don't let the amount of "complaints" discourage you; almost all of them are superficial and just style nitpicks. I didn't spot anything actually wrong :-)
@dominikh Think I fixed all of them. And don't worry about giving feedback, is always good. I'm still learning go, and sometimes forget about the styling rules. Thanks! :)
Merged as 78f0940, thank you. The only code change that I added is that I changed counterclockwise
from int to bool. That didn't warrant another revision of this PR :)
There a few methods/properties missing. Which I will add later. But a lot can be done with the ones supported already.