v2: support go1.14 - Githubissues

dominikh / go-js-dom

MIT License

249 stars 42 forks source link

v2: support go1.14 #75

Closed inliquid closed 4 years ago

inliquid commented 4 years ago

Fixes #74 /cc @dmitshur

dmitshur commented 4 years ago

Thanks for starting this work, @inliquid. I've finally had a chance to review.

This looks good and is functional, but I think we should make the following changes:

Rename the existing dom.go and events.go to dom_go113.go and events_go113.go, make the new 1.14+ files be dom.go and events.go since they're more important.
Don't convert the switches into if/else if statements, keep them as switches. See https://github.com/dominikh/go-js-dom/issues/74#issuecomment-615941119.

inliquid commented 4 years ago

@dmitshur I renamed files as you suggested, however, the proposed switch/case construction will not work because Equal returns bool:

dmitshur commented 4 years ago

Thanks for doing that. Sorry, I missed the notification for this earlier.

I'm quite sure the switch/case construction works, perhaps there was some issue when you tried it. Please see the commit I pushed.

inliquid commented 4 years ago

Thank you, I didn't notice that there is nothing after ; in initialization statement of switch. Looks a little bit magical and I would prefer if/else as they seem more natural, but anyways...