dominikh / go-mode.el

Emacs mode for the Go programming language
BSD 3-Clause "New" or "Revised" License
1.37k stars 209 forks source link

Merge go-capf into go-mode #359

Closed phikal closed 3 years ago

phikal commented 4 years ago

Hi, I have been maintaining go-capf (a completion-at-point-functions function) for a year now, and find it to be quite stable.

Due to the gopls developments I am unsure if there is any interest in a gocode frontend anymore, but I would like to propose merging go-capf into go-mode anyways. If the maintainers agree, I'll be happy do to all the work.

The code is public domain, so there should be no licensing issues.

muirdm commented 3 years ago

Thank you for the proposal. Considering gocode is effectively deprecated and lsp-mode/eglot provide featureful completion out of the box, I don't see much value in moving go-capf into go-mode. If anything go-mode will be reducing its scope and deprecating existing features in favor of LSP.

phikal commented 3 years ago

Ok, I'll close the issue then.