search

dominikh / go-mode.el

Emacs mode for the Go programming language
BSD 3-Clause "New" or "Revised" License
1.37k stars 209 forks source link

fix: go-guru-definition jump to wrong position by wrong coding-system. #366

Closed tangxinfa closed 2 years ago

tangxinfa commented 4 years ago

When default coding-system is "utf-8-unix" and open a file with "utf-8-dos" coding-system, go-guru-definition will jump to wrong position.

This is because windows's EOL is "\r\n", is different with linux's "\n", so we must keep the EOL unchanged when process internally.

tangxinfa commented 4 years ago

go-guru-hl-identifier also has the similar problem, but i don't know how to fix it.

dominikh commented 2 years ago

guru is unmaintained and doesn't support Go modules. The way forward is to use gopls instead. We won't tinker with the existing implementation.