search

dominikh / go-mode.el

Emacs mode for the Go programming language
BSD 3-Clause "New" or "Revised" License
1.37k stars 209 forks source link

Add dependency on Emacs 26.1 #397

Closed skangas closed 2 years ago

skangas commented 2 years ago

This adds an explicit dependency on Emacs 26.1. According to package-lint-current-buffer in go-mode.el:

1930:18: error: You should depend on (emacs "26.1") if you need `make-nearby-temp-file'.
1956:43: error: You should depend on (emacs "26.1") if you need `file-local-name'.
1960:36: error: You should depend on (emacs "26.1") if you need `file-local-name'.
2004:46: error: You should depend on (emacs "26.1") if you need `file-local-name'.

There is also a dependency on xref, which was first included in Emacs 25.1. Thanks.

EDIT: I also see that you now intend to depend on Emacs 26.1 (https://github.com/dominikh/go-mode.el/commit/32cbd78c0af29837ace3db04a224d6d01ec6851e).

dominikh commented 2 years ago

Thanks.