dominikh / go-mode.el

Emacs mode for the Go programming language
BSD 3-Clause "New" or "Revised" License
1.37k stars 209 forks source link

Make `indent-tabs-mode' buffer local #433

Closed shynur closed 5 months ago

dominikh commented 5 months ago

I don't believe this is necessary? According to its documentation, indent-tabs-mode automatically becomes buffer-local when set.

shynur commented 5 months ago

Oops, sorry! I indeed overlooked this. Due to my configuration issues, the value of indent-tabs-mode was never what I expected. Modifying the code in go-mode seemed to have solved my problem, but now it looks like I must have missed something. How embarrassing.

This can be closed now. (Yet I think it's not bad to use setq-local to explicitly indicate the variable is buffer-local.)

dominikh commented 5 months ago

Yet I think it's not bad to use setq-local to explicitly indicate the variable is buffer-local

I agree, but we'll do that as part of the tree-sitter rewrite of go-mode. Thanks!