search

dominikh / go-mode.el

Emacs mode for the Go programming language
BSD 3-Clause "New" or "Revised" License
1.37k stars 209 forks source link

Add go-{browse-{freesymbols,doc,assembly},rename} #439

Closed adonovan closed 2 weeks ago

adonovan commented 3 weeks ago

These four helper functions provide convenient ways to access gopls server functionality without the user needing to worry about how their LSP client does things. They should work for eglot and lsp-mode (though I haven't tested the latter).

Updates dominikh/go-mode.el/#436

adonovan commented 3 weeks ago

(Don't merge this yet: I've come around to using the go-browse-* naming for all the verbs that open a browser, so I'll update the PR to fix doc and assembly too.)

adonovan commented 2 weeks ago

(Don't merge this yet: I've come around to using the go-browse-* naming for all the verbs that open a browser, so I'll update the PR to fix doc and assembly too.)

Done. Please take another look.

adonovan commented 2 weeks ago

We're planning to release gopls/v0.16 today, and its release notes will mention these new functions; it would be great if we could merge this PR soon. Do let me know if there's anything you need from me.

dominikh commented 2 weeks ago

@adonovan Sorry for the delay. It's been merged to master now. Do you need a tagged release, or are people used to installing from master?

adonovan commented 2 weeks ago

@adonovan Sorry for the delay. It's been merged to master now. Do you need a tagged release, or are people used to installing from master?

No need to tag release; I have learned that Emacs users don't expect things to be easy. ;-)

Thanks.