search

dominikhlbg / BrotliHaxe

BrotliHaxe - hand ported decoder & encoder in haxe => JavaScript, PHP, Python, Java, C# (Project dev: 2013-2015 release: 2017)
MIT License
80 stars 9 forks source link

Haxe 4.2.3 #7

Open paulushub opened 3 years ago

paulushub commented 3 years ago

Compiling with the current compiler fails with the following messages

src/FunctionMalloc.hx:10: characters 3-30 : Warning : Structures with new are deprecated, use haxe.Constraints.Constructible instead
src/FunctionMalloc.hx:14: characters 3-49 : Warning : Structures with new are deprecated, use haxe.Constraints.Constructible instead
src/FunctionMalloc.hx:18: characters 3-51 : Warning : Structures with new are deprecated, use haxe.Constraints.Constructible instead
src/decode/Transforms.hx:140: character 22 : Invalid escape sequence \x. Values greater than \x7f are not allowed. Use \u00c2 instead.

Any help or updates?

barisyild commented 1 year ago

I think the optimization of this port is not very good, I'm sure that if haxe.io.Bytes is used, it will give very good results on every platform.

HughPH commented 6 months ago

Compiling to C# with 4.2.3 it just tells me:

Type not found : Main

HughPH commented 6 months ago

I'd like to see what Haxe 4.x produces, but I'm not sure I have the inclination to dig into it. In the code produced by 3.x it's not easy to see where Haxe ends and where Brotli begins - and there are some places where I wonder if generics would have been useful.