dominiksalvet / asus-fan-control

Fan control for ASUS devices running Linux
MIT License
317 stars 37 forks source link

Add support for ROG Strix SCAR III #6

Closed azamet90 closed 3 years ago

azamet90 commented 4 years ago
┌─[azamet@localhost]─[/tmp/gitpack]
└──╼ $sudo gitpack install github.com/dominiksalvet/asus-fan-control
/usr/local/bin/asus-fan-control: Missing temperatures for your notebook model or they are invalid. Falling back to UX430UA temperatures.
[install] github.com/dominiksalvet/asus-fan-control 2.9.1
┌─[azamet@localhost]─[/tmp/gitpack]
└──╼ $asus-fan-control
/usr/local/bin/asus-fan-control: Please run as root.
┌─[✗]─[azamet@localhost]─[/tmp/gitpack]
└──╼ $sudo asus-fan-control
/usr/local/bin/asus-fan-control: Missing temperatures for your notebook model or they are invalid. Falling back to UX430UA temperatures.

have the laptop model g731gv

dominiksalvet commented 4 years ago

@azamet90 Hello and welcome! As long as your notebook's fan is being controlled after the installation, everything is fine and expected - your model is not supported yet and hence the error reports.

However, by my search I expect that your notebook model has two fans - I do not have a clue how it reacts in this situation or whether it works at all.

Anyway, take a closer look at this guide on adding a new notebook model support and proceed as stated (with issue already created).

Please, let me know how things are going. Tomorrow, I can take a closer look at it.

azamet90 commented 4 years ago

okay i will try it let this topic stay open

also this is the place i have to look right?

Testing a new notebook model

If you are about to test an ASUS notebook model that hasn't been tested before, you should know that none of asus-fan-control authors is responsible for possible damage that it can cause to your device because the program uses ACPI calls and it modifies data on some addresses. Nevertheless, target addresses should be set to their default values on tested models when rebooting the system.

Provided you are aware of the fact stated above and the program is working on your device, try to find the best temperature configuration for your device using the sudo asus-fan-control -set-temps: command. Then follow the steps described in the Suggestions section and add the outputs of sudo asus-fan-control -get-temps and sudo dmidecode -s system-product-name commands to the issue text. If the issue is approved, your model will be added to the Tested notebook models list and the program will recognize it.

dominiksalvet commented 4 years ago

Yop, you are right - you do not have to create a new issue and use this one instead. Once I know that asus-fan-control really works on your device (see below), I change issue labels to make it more relevant.

However, I need additional information from you right now - is asus-fan-control affecting your's fan speed as per its current state? Optionally, try asus-fan-control -set-temps:<numbers> as shown in this example and let me know whether it affects the fan speed and how - I mean in case you really have two fans setup, I would like to also know which one is affected (CPU or GPU), or whether both are affected.

Thank you very much! :rocket:

azamet90 commented 4 years ago

Yop, you are right - you do not have to create a new issue and use this one instead. Once I know that asus-fan-control really works on your device (see below), I change issue labels to make it more relevant.

However, I need additional information from you right now - is asus-fan-control affecting your's fan speed as per its current state? Optionally, try asus-fan-control -set-temps:<numbers> as shown in this example and let me know whether it affects the fan speed and how - I mean in case you really have two fans setup, I would like to also know which one is affected (CPU or GPU), or whether both are affected.

Thank you very much! rocket

sorry for delay but i will today do it definitifly after if these things fails can i remove this tool completely? this is more important for me after fresh install because of i dont want to do fresh install again :D if you can help me with uninstall it completely i will try now this tool with that commands you give

edit:

now i did this command : sudo asus-fan-control -set-temps:'35 40 45 50 55 60 65 70'

but how to know if it is working? sudo asus-fan-control have no output?

edit: here is what i did more:

┌─[azamet@localhost]─[/Downloads]
└──╼ $sudo asus-fan-control
┌─[azamet@localhost]─[/Downloads]
└──╼ $sudo asus-fan-control -set-temps:'35 40 45 50 55 60 65 70'
┌─[azamet@localhost]─[/Downloads]
└──╼ $sudo asus-fan-control -h
/usr/local/bin/asus-fan-control: The option '-h' was not recognized.
┌─[✗]─[azamet@localhost]─[/Downloads]
└──╼ $sudo asus-fan-control -help
USAGE: /usr/local/bin/asus-fan-control [OPTION]...
OPTION:
  -get-temps            show current temperatures of fan speed levels
  -set-default-temps    use default temperatures for fan speed levels
  -set-temps:<numbers>  use custom temperatures for fan speed levels
  -help                 show this help and exit
  -about                show information and exit
  -version              show version and exit
┌─[azamet@localhost]─[/Downloads]
└──╼ $sudo asus-fan-control -get-temps
55 56 57 58 59 60 61 62
┌─[azamet@localhost]─[/Downloads]
└──╼ $sudo asus-fan-control -about
asus-fan-control 2.9.1
Fan control for ASUS devices running Linux.

Copyright 2017-2019 Dominik Salvet
github.com/dominiksalvet/asus-fan-control

as you can si after set-temps if i do get-temps nothing is changed is another problem too

i dont listen any sound from my fan now i think it is stopped working huh? because of non of the sensor tools working for my fan i cannot know it

on boot i get this error too: /usr/local/bin/asus-fan-control: Missing temperatures for your notebook model or they are invalid. Falling back to UX430UA temperatures.

dominiksalvet commented 4 years ago

All right, first things first.

Complete uninstallation may be performed as follows:

  1. Uninstall asus-fan-control using GitPack - sudo gitpack uninstall github.com/dominiksalvet/asus-fan-control - that will remove the program itself.
  2. Its configuration is kept in /etc/asus-fan-control directory and may be manually removed (it is not removed by GitPack to make asus-fan-control updating possible).
  3. If you had not had configured acpi_call kernel module before asus-fan-control installation (which is my case after fresh Ubuntu 18.04 install), you can also remove it. Remove lines containing acpi_call from /etc/modules file. You can also remove the acpi_call provider package - use sudo apt-get remove acpi-call-dkms (which again is not installed in my case after fresh OS install).
  4. Reboot your device.

PS: Despite of trying to be comprehensive, note that some files may left untouched but they should not affect an OS at all.


Please provide more information - output of sudo dmidecode -s system-product-name. So far it looks like your system has different ACPI addresses than tested models, which is not a good sign.


Try to listen the fan/s as temperature configuration changes and report what you have heard:

  1. Use sudo asus-fan-control -set-temps:'20 25 30 35 40 45 50 55' - now you certainly should hear your fan/s quite a loudly.
  2. Use sudo asus-fan-control -set-temps:'80 81 82 83 84 85 86 87' - now you should not hear any sound produced by fan/s at all.

PS: Use the commands above only in idle state - meaning no intensive program running alongside!


Please beautify terminal output and code properly. For inline styling, use `echo hi`. To style multiple lines, use:

``` echo hi echo hello ```

PS: Please include this styling also in your previous posts to make them more readable for newcomers. Thank you. :heart:

azamet90 commented 4 years ago

All right, first things first.

Complete uninstallation may be performed as follows:

1. Uninstall asus-fan-control using GitPack - `sudo gitpack uninstall github.com/dominiksalvet/asus-fan-control` - that will remove the program itself.

2. Its configuration is kept in _/etc/asus-fan-control_ directory and may be manually removed (it is not removed by GitPack to make asus-fan-control updating possible).

3. If you had not had configured acpi_call kernel module before asus-fan-control installation (which is my case after fresh Ubuntu 18.04 install), you can also remove it. Remove lines containing `acpi_call` from _/etc/modules_ file. You can also remove the acpi_call provider package - use `sudo apt-get remove acpi-call-dkms` (which again is not installed in my case after fresh OS install).

4. Reboot your device.

PS: Despite of trying to be comprehensive, note that some files may left untouched but they should not affect an OS at all.

Please provide more information - output of sudo dmidecode -s system-product-name. So far it looks like your system has different ACPI addresses than tested models, which is not a good sign.

Try to listen the fan/s as temperature configuration changes and report what you have heard:

1. Use `sudo asus-fan-control -set-temps:'20 25 30 35 40 45 50 55'` - now you certainly should hear your fan/s quite a loudly.

2. Use `sudo asus-fan-control -set-temps:'80 81 82 83 84 85 86 87'` - now you should not hear any sound produced by fan/s at all.

PS: Use the commands above only in idle state - meaning no intensive program running alongside!

Please beautify terminal output and code properly. For inline styling, use echo hi. To style multiple lines, use:

echo hi
echo hello

PS: Please include this styling also in your previous posts to make them more readable for newcomers. Thank you. heart

sudo dmidecode -s system-product-name
[sudo] password for azamet: 
ROG Strix G731GV_G731GV

i did tryed to use video rendering to see if the fan works and it works but starting to work later then before i think something like after maybe 65 celsius :/ of course im noob i think it so because of i do watch sensors command during video rendering and listen the fan sound same time... like i said before if i do set temp after get temp the result of get temp is same and now i do have full time for this if you are here

 azamet@localhost]─[~]
└──╼ $sudo asus-fan-control -set-temps:'20 25 30 35 40 45 50 55'
sudo asus-fan-control -get-temps
55 56 57 58 59 60 61 62

next time i will use pastebin because of some charachters on my terminal the code is changing here because of i do have the bashrc changed

whatever i do i get this output from get-temp command 55 56 57 58 59 60 61 62

edit: after remove the acpi-kernel-dkms which is on default was not installed i do get this error on boot: Failed to start Load Kernel Modules. Failed to find module 'acpi_call'

how to fix it?

edit: fixed the problem with doing this:

If you had not had configured acpi_call kernel module before asus-fan-control installation (which >is my case after fresh Ubuntu 18.04 install), you can also remove it. Remove lines containing >acpi_call from /etc/modules file.

dominiksalvet commented 4 years ago

@azamet90 I am really sorry but your model seems to have symptoms of unsupported models as also seen in #4. I can't do anything. :disappointed:

There is only one solution and it is quite dangerous; find ACPI fun addresses yourself. Then, add support for model-based addresses. I would rather recommend you to try other projects for fan control.

Still, if you are in (or anyone) and want to add support for this model, take a look at this post. It might be helpful as all current supported models are based on it. Please, let us know in case you find out something important.

@azamet90 Feel free to close this issue if you do not have additional comments. I am really sorry that I could not help you. :cry:

dominiksalvet commented 4 years ago

@azamet90 Hey, I have been thinking that it will be better for this issue to stay open to let people know that it is still not resolved and they can contribute by doing so. I believe that you agree.

azamet90 commented 4 years ago

++++++

azamet90 commented 4 years ago

any news?

dominiksalvet commented 4 years ago

@azamet90 Just for clarification - I am not working on it at all - I am just leaving it open for others to know that it needs to be solved. Anyways, no news from my side.


BTW, I recommend you to also watch #4 and #5 as it seems that they are related to each other.

dominiksalvet commented 4 years ago

Hi @azamet90! :wave:

Good news here! I have just released the 3.0.0 version with support for different base ACPI addresses among laptop models.

That means once you know/find the base ACPI fan address for your device, asus-fan-control can fully support it. Please, let me know if you do so. It would be so exciting to see this new feature actually being used! :rocket:

dominiksalvet commented 4 years ago

@azamet90 Another good news! :rocket:

I have created afc-scout program that can help you to find your base ACPI fan address. It is conveniently distributed using GitPack. Please give it a try. :+1:

Feel free to also take a look at the contributing guide, which has been updated to guide you through the process.

azamet90 commented 4 years ago

i was long time not here i see it now and is the tool now updated for my laptop model?

dominiksalvet commented 4 years ago

i was long time not here i see it now and is the tool now updated for my laptop model?

Not yet, your action is demanded for that. 😉 Give afc-scout a shot! 😃

azamet90 commented 4 years ago

@azamet90 Another good news! rocket

I have created afc-scout program that can help you to find your base ACPI fan address. It is conveniently distributed using GitPack. Please give it a try. +1

Feel free to also take a look at the contributing guide, which has been updated to guide you through the process.

hello sorry for extreme late but i did tryed to run it without installing and i get this error:

file /proc/acpi/call does not exist

cd /proc/acpi/
 azamet@MrRobots  /proc/acpi  ls
button  wakeup

before i was not able to see all the sensors but with the new kali kernel it is posible i dont know if it is useful but yeah...


hidpp_battery_0-hid-3-8
Adapter: HID adapter
in0:           3.75 V  

asus-isa-0000
Adapter: ISA adapter
cpu_fan:     3800 RPM

nvme-pci-0200
Adapter: PCI adapter
Composite:    +54.9°C  (low  =  -0.1°C, high = +81.8°C)
                       (crit = +84.8°C)
Sensor 1:     +54.9°C  (low  = -273.1°C, high = +65261.8°C)
Sensor 2:     +58.9°C  (low  = -273.1°C, high = +65261.8°C)

acpitz-acpi-0
Adapter: ACPI interface
temp1:        +59.0°C  (crit = +103.0°C)

iwlwifi_1-virtual-0
Adapter: Virtual device
temp1:        +51.0°C  

pch_cannonlake-virtual-0
Adapter: Virtual device
temp1:        +62.0°C  

coretemp-isa-0000
Adapter: ISA adapter
Package id 0:  +59.0°C  (high = +100.0°C, crit = +100.0°C)
Core 0:        +57.0°C  (high = +100.0°C, crit = +100.0°C)
Core 1:        +59.0°C  (high = +100.0°C, crit = +100.0°C)
Core 2:        +58.0°C  (high = +100.0°C, crit = +100.0°C)
Core 3:        +57.0°C  (high = +100.0°C, crit = +100.0°C)
Core 4:        +56.0°C  (high = +100.0°C, crit = +100.0°C)
Core 5:        +59.0°C  (high = +100.0°C, crit = +100.0°C)

BAT0-acpi-0
Adapter: ACPI interface
in0:          15.68 V ```

minimum 55 celcius please help :D
dominiksalvet commented 4 years ago

file /proc/acpi/call does not exist

GitPack installs acpi_call module as well. You need to install it manually then. You can use sudo apt install acpi-call-dkms.